From ae8373f116a8fcae3a35bcf7e28bb61247b84493 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sun, 9 Jun 2019 02:19:30 +0000 Subject: [PATCH] menu button: Use proper focus api Widgets are supposed to call gtk_widget_child_focus. Calling internal focus_move function directly makes us skip the childs ::focus() implementation, which is where the magic happens. --- gtk/gtkmenubutton.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk/gtkmenubutton.c b/gtk/gtkmenubutton.c index 7937982a77..c4813ebbc7 100644 --- a/gtk/gtkmenubutton.c +++ b/gtk/gtkmenubutton.c @@ -521,9 +521,9 @@ gtk_menu_button_focus (GtkWidget *widget, GtkMenuButtonPrivate *priv = gtk_menu_button_get_instance_private (button); if (priv->menu && gtk_widget_get_visible (priv->menu)) - return gtk_widget_focus_move (priv->menu, direction); + return gtk_widget_child_focus (priv->menu, direction); else if (priv->popover && gtk_widget_get_visible (priv->popover)) - return gtk_widget_focus_move (priv->popover, direction); + return gtk_widget_child_focus (priv->popover, direction); else return GTK_WIDGET_CLASS (gtk_menu_button_parent_class)->focus (widget, direction); } -- 2.30.2